Use events API to eager send attestations #7892
Open
+752
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
added
the
waiting-on-author
hopinheimer
added
ready-for-review
hopinheimer
removed
the
waiting-on-author
eserilev
reviewed
Oct 15, 2025
hopinheimer
added
ready-for-review
dknopik
reviewed
Jan 8, 2026
|
Some required checks have failed. Could you please take a look @hopinheimer? 🙏 |
mergify
bot
added
waiting-on-author
| let mut last_slot = self.latest_attested_slot.lock().await; | ||
|
|
||
| if current_slot <= *last_slot { | ||
| debug!(?current_slot, "Attestation already initiated for the slot"); |
Member
There was a problem hiding this comment.
This log is a bit noisy, it's happening even on my VC with only a single validator, and at slots my validator is not even attesting.
I think the flow is:
- Head event arrives
- Trigger attestation service
- Nothing to do (not an attester), update latest slot
- Go round the loop again
- Still the same slot, so wait for slot + 1/3
- 1/3 of slot arrives, we've already set
last_slot-> log message
Maybe we should add a sleep at the end of this loop until the next slot so that we don't wrap round like this
Member
There was a problem hiding this comment.
Maybe the sleep should be until the start of the original slot + 1 actually, just in case the attestation process takes a long time. We don't want "next slot" to actually be slot + 2 by the time this calculation is done
hopinheimer
added
ready-for-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #7820
I haven't done benches for the change in kurtosis but post results soon